Add CSS Color 4 gradient options to CanvasGradient #50878
Merged
+4,422
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423255}
wpt-pr-bot
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ColorInterpolationMethod, HueInterpolationMethod and
premultipliedAlpha attributes to CanvasGradient as described here:
whatwg/html#7947
This is done behind the flag CanvasGradientCSSColor4, as spec is not yet
settled:
whatwg/html#10986
Chromestatus: https://chromestatus.com/feature/5168382242193408
I2P thread:
https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM
Gradient::ColorInterpolation is also renamed to
Gradient::PremultipliedAlpha, because that's what it is.
Subpixel antialiasing for test labels is being inconsistently applied on
windows, so the tests are marked as failing with a bug.
crbug.com/396344375
Bug: 394052224
Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1423255}