Command updates #50829
Merged
Command updates #50829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset buttons should no longer trigger popovertarget or commandfor behaviour
Invalid type buttons should no longer trigger commandfor behaviour
6 tasks
keithamus
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
This requires whatwg/html#11053 but I think that spec change is good, and I also think this looks to be a good change that accurately reflects the spec changes. So let's wait for whatwg/html#11053 then merge this.
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Feb 26, 2025
Reset buttons and inputs no longer trigger popover target activation behavior when there's a form owner. Reset buttons no longer trigger command button activation behavior when there's a form owner. Missing and invalid type buttons no longer trigger command button activation behavior when there's a form owner. Tests: web-platform-tests/wpt#50829.
This was referenced Mar 4, 2025
lozy219
pushed a commit
to lozy219/html
that referenced
this pull request
Mar 10, 2025
Reset buttons and inputs no longer trigger popover target activation behavior when there's a form owner. Reset buttons no longer trigger command button activation behavior when there's a form owner. Missing and invalid type buttons no longer trigger command button activation behavior when there's a form owner. Tests: web-platform-tests/wpt#50829.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update popovertarget and commandfor reset button tests
Reset buttons should no longer trigger popovertarget or commandfor behaviour
Update commandfor invalid button tests
Invalid type buttons should no longer trigger commandfor behaviour