Merge pull request #288 from weaviate/fix-transfomers-module-configuration-with-enabled-pool

Fix transformers module running with enabled pool

Author: antas-marcin

weaviate/Chart.yaml

@@ -7,7 +7,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 17.4.0
+version: 17.4.1
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

weaviate/templates/transformersInferenceDeployment.yaml

@@ -36,6 +36,11 @@ spec:
       - name: {{ index $module "fullnameOverride" }}
         image: {{ index $module "registry" }}/{{ index $module "repo" }}:{{ index $module "tag" }}
         imagePullPolicy: {{ index $module "imagePullPolicy" }}
+        {{- if index $module "envconfig" "use_sentence_transformers_multi_process" }}
+        volumeMounts:
+          - mountPath: /dev/shm
+            name: devshm
+        {{- end }}
         env:
           - name: ENABLE_CUDA
             value: "{{ if index $module "envconfig" "enable_cuda" }}1{{ else }}0{{ end }}"
@@ -46,6 +51,8 @@ spec:
             value: {{ index $module "envconfig" "nvidia_driver_capabilities"}}
           - name: LD_LIBRARY_PATH
             value: {{ index $module "envconfig" "ld_library_path"}}
+          {{- end }}
+          {{- if index $module "envconfig" "use_sentence_transformers_multi_process" }}
           - name: USE_SENTENCE_TRANSFORMERS_MULTI_PROCESS
             value: "{{ if index $module "envconfig" "use_sentence_transformers_multi_process" }}1{{ else }}0{{ end }}"
           {{- end }}
@@ -88,6 +95,12 @@ spec:
       tolerations:
         {{ toYaml . | nindent 8 }}
       {{- end }}
+      {{- if index $module "envconfig" "use_sentence_transformers_multi_process" }}
+      volumes:
+        - name: devshm
+          emptyDir:
+            medium: Memory
+      {{- end }}
 ---
 apiVersion: v1
 kind: Service
@@ -141,6 +154,11 @@ spec:
       - name: {{ index $passage "fullnameOverride" }}
         image: {{ index $passage "registry" }}/{{ index $passage "repo" }}:{{ index $passage "tag" }}
         imagePullPolicy: {{ index $passage "imagePullPolicy" }}
+        {{- if index $passage "envconfig" "use_sentence_transformers_multi_process" }}
+        volumeMounts:
+          - mountPath: /dev/shm
+            name: passagedevshm
+        {{- end }}
         env:
           - name: ENABLE_CUDA
             value: "{{ if index $passage "envconfig" "enable_cuda" }}1{{ else }}0{{ end }}"
@@ -151,6 +169,8 @@ spec:
             value: {{ index $passage "envconfig" "nvidia_driver_capabilities"}}
           - name: LD_LIBRARY_PATH
             value: {{ index $passage "envconfig" "ld_library_path"}}
+          {{- end }}
+          {{- if index $passage "envconfig" "use_sentence_transformers_multi_process" }}
           - name: USE_SENTENCE_TRANSFORMERS_MULTI_PROCESS
             value: "{{ if index $passage "envconfig" "use_sentence_transformers_multi_process" }}1{{ else }}0{{ end }}"
           {{- end }}
@@ -185,6 +205,12 @@ spec:
       tolerations:
         {{ toYaml . | nindent 8 }}
       {{- end }}
+      {{- if index $passage "envconfig" "use_sentence_transformers_multi_process" }}
+      volumes:
+        - name: passagedevshm
+          emptyDir:
+            medium: Memory
+      {{- end }}
 ---
 apiVersion: v1
 kind: Service
@@ -235,6 +261,11 @@ spec:
       - name: {{ index $query "fullnameOverride" }}
         image: {{ index $query "registry" }}/{{ index $query "repo" }}:{{ index $query "tag" }}
         imagePullPolicy: {{ index $query "imagePullPolicy" }}
+        {{- if index $query "envconfig" "use_sentence_transformers_multi_process" }}
+        volumeMounts:
+          - mountPath: /dev/shm
+            name: querydevshm
+        {{- end }}
         env:
           - name: ENABLE_CUDA
             value: "{{ if index $query "envconfig" "enable_cuda" }}1{{ else }}0{{ end }}"
@@ -245,6 +276,8 @@ spec:
             value: {{ index $query "envconfig" "nvidia_driver_capabilities"}}
           - name: LD_LIBRARY_PATH
             value: {{ index $query "envconfig" "ld_library_path"}}
+          {{- end }}
+          {{- if index $query "envconfig" "use_sentence_transformers_multi_process" }}
           - name: USE_SENTENCE_TRANSFORMERS_MULTI_PROCESS
             value: "{{ if index $query "envconfig" "use_sentence_transformers_multi_process" }}1{{ else }}0{{ end }}"
           {{- end }}
@@ -279,6 +312,12 @@ spec:
       tolerations:
         {{ toYaml . | nindent 8 }}
       {{- end }}
+      {{- if index $query "envconfig" "use_sentence_transformers_multi_process" }}
+      volumes:
+        - name: querydevshm
+          emptyDir:
+            medium: Memory
+      {{- end }}
 ---
 apiVersion: v1
 kind: Service