Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radius computation when normalizing ray directions #19

Open
MrMois opened this issue Oct 26, 2023 · 3 comments
Open

Radius computation when normalizing ray directions #19

MrMois opened this issue Oct 26, 2023 · 3 comments

Comments

@MrMois
Copy link

MrMois commented Oct 26, 2023

Hello, I got a question regarding the ball radius.

In camera.py the ray directions are normalized, hence t values (and distances) are in euclidean space. But the radii are computed on the image plane w.r.t. the unnormalized distances. Shouldn't the radii also be scaled by 1 / ||directions|| before the directions are normalized so you get the radii on the unit sphere?

Greets!

@hesom
Copy link

hesom commented Oct 26, 2023

I think that is done in compute_ball_radii inside trimipRF.py. The radii are scaled depending on the angle to the principal camera ray.

@Fjzd
Copy link

Fjzd commented Nov 17, 2023

Hello, I got a question regarding the ball radius.

In camera.py the ray directions are normalized, hence t values (and distances) are in euclidean space. But the radii are computed on the image plane w.r.t. the unnormalized distances. Shouldn't the radii also be scaled by 1 / ||directions|| before the directions are normalized so you get the radii on the unit sphere?

Greets!

I have the same question , i ’m looking forward to relative reply!

@ysjue
Copy link

ysjue commented Dec 9, 2023

The radii are comupted on a virtual imaging plane with a depth value (coordinate along z-axis) as 1 w.r.t. the camera frame. No matter whether rays are normalized or not, this unit depth value has defined coordinates of these pixels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants