Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the reading of the IP addresses from the config.yml file #143

Open
rauldpm opened this issue Mar 21, 2023 · 5 comments
Open

Improve the reading of the IP addresses from the config.yml file #143

rauldpm opened this issue Mar 21, 2023 · 5 comments
Assignees
Labels
level/task Task issue type/bug Bug issue

Comments

@rauldpm
Copy link
Member

rauldpm commented Mar 21, 2023

Description

The config.yml configuration file specifies an IP format of the form ip: <indexer-node-ip>, where <indexer-node-ip> must be replaced by the IP address (including <>), this is not specified in the documentation and we delegate to the users the part where it is understood that the characters < and > must be replaced since they are used as markers.

To avoid this, we should only specify a more understandable option where if there is a delimiter character it is also accepted, for example:

  • ip: indexer-node-ip
  • ip: "indexer-node-ip"

Another option would be to modify the Wazuh installation assistant so that it removes the delimiter characters in case they are entered.

Related: https://www.reddit.com/r/Wazuh/comments/11xcy7b/wazuh_installation_assistant_indexer_installation

@rauldpm rauldpm added the type/enhancement Enhancement issue label Mar 21, 2023
@teddytpc1 teddytpc1 added the level/task Task issue label Jun 7, 2023
@teddytpc1 teddytpc1 added type/bug Bug issue and removed type/enhancement Enhancement issue labels May 15, 2024
@CarlosALgit CarlosALgit self-assigned this Nov 18, 2024
@CarlosALgit CarlosALgit transferred this issue from wazuh/wazuh-packages Nov 18, 2024
@wazuhci wazuhci moved this from Backlog to In progress in XDR+SIEM/Release 5.0.0 Nov 18, 2024
@CarlosALgit
Copy link
Member

Update Report

I've been reading the code and trying some solutions to this, but the regex is hard to understand and to tune.

@CarlosALgit
Copy link
Member

Update Report

The changes have been made and pushed to the branch. The tests are passing okay. It remains to do more tests and talk with the team where can the changes impact if I'm missing something.
I pass this issue to On Hold due to reasons above and to prioritise https://github.com/wazuh/wazuh-automation/issues/1954

@wazuhci wazuhci moved this from In progress to On hold in XDR+SIEM/Release 5.0.0 Nov 19, 2024
@CarlosALgit
Copy link
Member

Update Report

The team is reviewing these changes in order to double check if I'm missing impact somewhere.

@wazuhci wazuhci moved this from On hold to Pending review in XDR+SIEM/Release 5.0.0 Nov 20, 2024
@wazuhci wazuhci moved this from Pending review to Blocked in XDR+SIEM/Release 5.0.0 Nov 20, 2024
@CarlosALgit
Copy link
Member

Update Report

After reviewing these changes we think that allowing the IP to be betweeen < > is a bad solution due to the standard for updating fields from the user side is letting the < > in the specified field.

So, the solution we see is to improve the error output to make it clearer when the IP is wrote between < >.

However, the Cert Tool may not be supported from 5.0 onwards, so for now the issue remains blocked.

@teddytpc1
Copy link
Member

Javi: The cert tool must exist (it should be improved actually) and owned by DevOps.

@wazuhci wazuhci moved this from Blocked to Backlog in XDR+SIEM/Release 5.0.0 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
Status: Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants