-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the reading of the IP addresses from the config.yml file #143
Comments
Update ReportI've been reading the code and trying some solutions to this, but the regex is hard to understand and to tune. |
Update ReportThe changes have been made and pushed to the branch. The tests are passing okay. It remains to do more tests and talk with the team where can the changes impact if I'm missing something. |
Update ReportThe team is reviewing these changes in order to double check if I'm missing impact somewhere. |
Update ReportAfter reviewing these changes we think that allowing the IP to be betweeen So, the solution we see is to improve the error output to make it clearer when the IP is wrote between However, the Cert Tool may not be supported from 5.0 onwards, so for now the issue remains blocked. |
Javi: The cert tool must exist (it should be improved actually) and owned by DevOps. |
Description
The
config.yml
configuration file specifies an IP format of the formip: <indexer-node-ip>
, where<indexer-node-ip>
must be replaced by the IP address (including<>
), this is not specified in the documentation and we delegate to the users the part where it is understood that the characters<
and>
must be replaced since they are used as markers.To avoid this, we should only specify a more understandable option where if there is a delimiter character it is also accepted, for example:
ip: indexer-node-ip
ip: "indexer-node-ip"
Another option would be to modify the Wazuh installation assistant so that it removes the delimiter characters in case they are entered.
Related: https://www.reddit.com/r/Wazuh/comments/11xcy7b/wazuh_installation_assistant_indexer_installation
The text was updated successfully, but these errors were encountered: