Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build workflow version getter #720

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Conversation

f-galland
Copy link
Member

Description

The builder workflow was referencing the old format VERSION file to get the version number, where it should be calling the product_version.sh script. This PR fixes that issue.

Related Issues

Closes #718

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

@f-galland f-galland self-assigned this Feb 27, 2025
@f-galland f-galland marked this pull request as ready for review February 27, 2025 17:10
@f-galland f-galland requested a review from a team as a code owner February 27, 2025 17:10
Copy link
Member

@mcasas993 mcasas993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-galland f-galland merged commit f717904 into main Feb 27, 2025
22 checks passed
@f-galland f-galland deleted the 718-fix-build-workflow-version branch February 27, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexers packages fails to built for main branch due to the absence of VERSION file
2 participants