Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version file standarization #693

Merged
merged 15 commits into from
Feb 20, 2025
Merged

Conversation

f-galland
Copy link
Member

Description

This PR updates the VERSION file to the new specification here:

Related Issues

Resolves #685

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

@f-galland f-galland self-assigned this Feb 18, 2025
@f-galland f-galland linked an issue Feb 18, 2025 that may be closed by this pull request
4 tasks
@f-galland
Copy link
Member Author

.deb

Packages are installed and VERSION.json can be found under /usr/share/wazuh-indexer with the right format.

root@ubuntu:~# dpkg -i wazuh-indexer_4.12.0-0_amd64_2df18a8.deb 
Selecting previously unselected package wazuh-indexer.
(Reading database ... 16339 files and directories currently installed.)
Preparing to unpack wazuh-indexer_4.12.0-0_amd64_2df18a8.deb ...
Running Wazuh Indexer Pre-Installation Script
Unpacking wazuh-indexer (4.12.0-0) ...
Setting up wazuh-indexer (4.12.0-0) ...
Running Wazuh Indexer Post-Installation Script
### NOT starting on installation, please execute the following statements to configure wazuh-indexer service to start automatically using systemd
 sudo systemctl daemon-reload
 sudo systemctl enable wazuh-indexer.service
### You can start wazuh-indexer service by executing
 sudo systemctl start wazuh-indexer.service

root@ubuntu:~# cat /usr/share/wazuh-indexer/VERSION.json 
{
  "version": "4.12.0",
  "stage": "alpha1",
  "commit": "2df18a8"
}

@f-galland
Copy link
Member Author

f-galland commented Feb 19, 2025

.rpm

Packages are installed and VERSION.json can be found under /usr/share/wazuh-indexer with the right format.

[root@alma9 ~]# rpm -ivh wazuh-indexer_4.12.0-0_x86_64_2df18a8.rpm 
Verifying...                          ################################# [100%]
Preparing...                          ################################# [100%]
Updating / installing...
   1:wazuh-indexer-4.12.0-0           ################################# [100%]
### NOT starting on installation, please execute the following statements to configure wazuh-indexer service to start automatically using systemd
 sudo systemctl daemon-reload
 sudo systemctl enable wazuh-indexer.service
### You can start wazuh-indexer service by executing
 sudo systemctl start wazuh-indexer.service
[root@alma9 ~]# cat /usr/share/wazuh-indexer/VERSION.json 
{
  "version": "4.12.0",
  "stage": "alpha1",
  "commit": "2df18a8"
}

@f-galland f-galland marked this pull request as ready for review February 19, 2025 18:40
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexRuiz7 AlexRuiz7 merged commit 9ad8420 into 4.12.0 Feb 20, 2025
10 checks passed
@AlexRuiz7 AlexRuiz7 deleted the 685-version-file-standarization branch February 20, 2025 14:18
AlexRuiz7 pushed a commit that referenced this pull request Feb 20, 2025
* Update VERSION file format

* Add json extension to VERSION file

* Fix VERSION.json path in assemble.sh

* Allow ci dockers access to the repository's top level

* Obtain hash in assemble stage

* Restore distribution/packages/src/rpm/wazuh-indexer.cicd.spec

Signed-off-by: Fede Galland <99492720+f-galland@users.noreply.github.com>

* Remove comments from ci.yml

* Fix error in rpm assemble stage

* Abstract version function to script

* Remove old VERSION file again

* Re add cicd spec file

---------

Signed-off-by: Fede Galland <99492720+f-galland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version file standardization
2 participants