Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor nit] toolchain install missing download detials #54

Open
nuke-web3 opened this issue Mar 2, 2024 · 1 comment
Open

[Minor nit] toolchain install missing download detials #54

nuke-web3 opened this issue Mar 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nuke-web3
Copy link

Attempting to install the toolchain on a very slow (KB/s) hangs on Extracting... but I believe that message is printed too early, while the download is progressing still:

// Download and extract sysroot.
eprintln!(
"Downloading sysroot from url '{}'...",
&sysroot_asset.browser_download_url
);
let res = client
.get(&sysroot_asset.browser_download_url)
.send()?
.error_for_status()?;
eprintln!("Extracting...");

Some minimal progress bar would be great, but at least ensuring that it is clear what is blocking the install step-wise would be a very nice fix to have.


# Run in a rust crate:
cargo wasix build

Finding latest release... (https://api.github.com/repos/wasix-org/rust/releases/latest)...
Toolchain path ~/.local/share/cargo-wasix/toolchains/x86_64-unknown-linux-gnu_v2023-11-01.1 already exists - deleting existing files!
Downloading sysroot from url 'https://github.com/wasix-org/rust/releases/download/v2023-11-01.1/wasix-libc.tar.gz'...
Extracting...
Downloading Rust toolchain from url 'https://github.com/wasix-org/rust/releases/download/v2023-11-01.1/rust-toolchain-x86_64-unknown-linux-gnu.tar.gz'...
Extracting...

# hangs for ~1 minute or more here

Downloaded toolchain x86_64-unknown-linux-gnu to /home/nuke/.local/share/cargo-wasix/toolchains/x86_64-unknown-linux-gnu_v2023-11-01.1/rust
Activating rustup toolchain wasix at /home/nuke/.local/share/cargo-wasix/toolchains/x86_64-unknown-linux-gnu_v2023-11-01.1/rust...
Running rustup toolchain link wasix /home/nuke/.local/share/cargo-wasix/toolchains/x86_64-unknown-linux-gnu_v2023-11-01.1/rust:
rustup toolchain wasix was linked and is now available!
@theduke theduke added the enhancement New feature or request label Mar 7, 2024
@theduke
Copy link
Collaborator

theduke commented Mar 7, 2024

Yes agreed, the current output isn't great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants