Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme support #3

Open
vasilp opened this issue May 14, 2017 · 3 comments
Open

Theme support #3

vasilp opened this issue May 14, 2017 · 3 comments
Assignees

Comments

@vasilp
Copy link

vasilp commented May 14, 2017

To enable theme support (for example bootstrap), this needs to be added in the initialization of the paert select2 object:

self.select2 = self.$element.select2({
...
theme: options.theme,
...
})...

This is line 22 in the current version.

@vasilp
Copy link
Author

vasilp commented Sep 4, 2017

Hi,
Any progress on that?

@wasikuss
Copy link
Owner

fix in progress - requires changes in multi-checkboxes api, due to conflict with function names in core select2.

@wasikuss wasikuss self-assigned this Jan 31, 2018
@vasilp
Copy link
Author

vasilp commented Mar 10, 2019

Hi, the component is very useful. Considering the theme support ... the fix I posted in the OP is working properly with bootstrap theme for example - it just passes on the theme parameter.

Seems a valid fix just to be added this line of the code, on line 19 in the current version of the plugin.
I can do a PR if you need ? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants