Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for StructBlock classes with custom StructValues #76

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

jams2
Copy link
Contributor

@jams2 jams2 commented Jun 14, 2023

Fixes #72

@jams2 jams2 marked this pull request as draft June 14, 2023 16:00
@jams2 jams2 marked this pull request as ready for review June 17, 2023 15:44
@jams2
Copy link
Contributor Author

jams2 commented Feb 18, 2024

@zerolab if I can beg a little of your time, this could use a review as well 🙏

Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (subject to a rebase and linting session ;))

@jams2 jams2 force-pushed the custom-struct-value-classes branch from d27f1a4 to 5c59ea9 Compare February 19, 2024 16:42
@jams2 jams2 merged commit 654a5e9 into wagtail:main Feb 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StructBlockFactory does not support custom StructValue classes
2 participants