Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing and coverage tools #86

Closed
5 tasks
jams2 opened this issue Feb 18, 2024 · 5 comments
Closed
5 tasks

Update testing and coverage tools #86

jams2 opened this issue Feb 18, 2024 · 5 comments

Comments

@jams2
Copy link
Contributor

jams2 commented Feb 18, 2024

coverage and the pytest plugins declared in setup.py are out of date and could use updating.

See:

Tasks:

  • Remove pytest-pythonpath, update setup.cfg python_paths to pythonpath if necessary
  • Upgrade pytest
  • Upgrade pytest-django
  • Upgrade pytest-cov
  • Upgrade coverage
@Krishnag09
Copy link

could you please assign this to me.

@jams2
Copy link
Contributor Author

jams2 commented Feb 19, 2024

Hi @Krishnag09, I believe tickets are not typically assigned outside of the Wagtail core team, but do feel free to pick this up and start working on it :)

@Krishnag09
Copy link

I have the changes ready but would need access to push.

@jams2
Copy link
Contributor Author

jams2 commented Feb 22, 2024

Hi @Krishnag09 , you should:

  1. create a fork of this repository in your own github account;
  2. clone your fork to your computer;
  3. create a new branch for your work;
  4. commit your work to your new branch;
  5. push those changes to your github repository; and
  6. open a pull request on this repository, from your branch targeting main.

Once your changes have been reviewed, tested, and any necessary changes have been made, a maintainer of this package will merge them.

@jams2
Copy link
Contributor Author

jams2 commented May 24, 2024

Solved by #91

@jams2 jams2 closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants