Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nftaa_m1.md #1243

Merged
merged 4 commits into from
Feb 5, 2025
Merged

nftaa_m1.md #1243

merged 4 commits into from
Feb 5, 2025

Conversation

Roman-24
Copy link
Contributor

@Roman-24 Roman-24 commented Jan 28, 2025

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2396

@keeganquigley keeganquigley self-assigned this Jan 28, 2025
@keeganquigley
Copy link
Contributor

Hi @Roman-24 thanks for the delivery. I was able to manually test all the pallet functionality. I was a bit confused by the structure; usually I should be able to run the unit tests from the pallet root dir, but I'm willing to pass it since I could run the tests from the node. Would be nice to see better test coverage as well on next milestone. Please see notes on my final evaluation. Overall great work!

@keeganquigley keeganquigley merged commit 2ce51a2 into w3f:master Feb 5, 2025
3 checks passed
Copy link

github-actions bot commented Feb 5, 2025

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

github-actions bot commented Feb 5, 2025

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants