Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCDT Milestone 1 #1241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

khalidzahra
Copy link

@khalidzahra khalidzahra commented Jan 22, 2025

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: Private application. Project name: tcdt

@PieWol PieWol self-assigned this Jan 23, 2025
@PieWol
Copy link
Member

PieWol commented Feb 3, 2025

Hey @khalidzahra ,
thanks again for splitting it up into two PR's. Sorry for the long wait here. I'll evaluate both Milestones this week.

@PieWol
Copy link
Member

PieWol commented Feb 7, 2025

Hey @khalidzahra ,
it looks like there is no license specified in the bcdns repository. It should be apache 2.0 though, right?

@khalidzahra
Copy link
Author

Hey @PieWol
Yes the license is Apache 2.0. I believe it is specified for the individual pallets, but I can specify it for the whole repository in the readme if you'd like :)

@PieWol
Copy link
Member

PieWol commented Feb 9, 2025

That would be a nice touch. Sadly I didn't manage to finish the review this week but I'm working on it and I'll get back to you in case of any questions. Sorry for the delay.

@khalidzahra
Copy link
Author

No worries! I added the licensing information to the project as you requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants