-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input.fileDialogOpened
+ unhandledPromptBehavior:file
#883
Merged
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ remove picker type + check prompt handler through all the sessions
This was referenced Feb 25, 2025
OrKoN
reviewed
Feb 25, 2025
OrKoN
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 tasks
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
cf917e3
to
fa27cff
Compare
This was referenced Feb 28, 2025
juliandescottes
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2 nits otherwise lgtm
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
input.fileDialogOpened
+ `unhandledPromptBehavior:file
input.fileDialogOpened
+ `unhandledPromptBehavior:file
input.fileDialogOpened
+ unhandledPromptBehavior:file
github-actions bot
added a commit
that referenced
this pull request
Mar 5, 2025
SHA: 3c02257 Reason: push, by sadym-chromium Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@juliandescottes PTAL on the w3c/webdriver#1884 |
sadym-chromium
added a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
Mar 6, 2025
Implementation of w3c/webdriver-bidi#883
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
input.fileDialogOpened
event and definesunhandledPromptBehavior
forfile
. It should be accompanied by the following changes:HTML spec: whatwg/html#11030
WebDriver Classic spec: w3c/webdriver#1884
File system access: WICG/file-system-access#452
Open questions:
browsingContext.userPromptOpened
? If so, there will be no way of subscribing only forinput.fileDialogOpened
event. Also, file dialogs are specific, as it does not supportbrowsingContext.handleUserPrompt
.Re-imagining the #568, addressing #494.
Preview | Diff