Create sections for individual operations #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twiss See https://pr-preview.s3.amazonaws.com/panva/webcrypto/pull/402.html#rsassa-pkcs1-operations, WDYT? It always bothered me that I cannot link to the individual algorithm's operation. |
|
Yeah, this has bothered me as well and I agree this is much better 👍 Thanks for (starting with) fixing this! |
|
Review link with no whitespace: https://github.com/w3c/webcrypto/pull/402/files?w=1, diff in the OP is surprisingly useful as well. |
|
@twiss this is ready. |
twiss
changed the title
github-actions bot
added a commit
that referenced
this pull request
Mar 7, 2025
SHA: c8b273d Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving individual algorithm operations to their own section to be able to get an anchor deep link for them.
Preview | Diff