Throw in AES-CBC decrypt operation for odd ciphertext lengths #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWiederhake
approved these changes
Oct 28, 2024
|
Any updates on this? |
If the ciphertext is not a positive multiple of 16 bytes, return an OperationError.
twiss
force-pushed
the
aes-cbc-handle-odd-length
branch
from
d2b4d2b to
52eed0f
Compare
|
I'll merge this despite the absence of feedback from WebKit because Chromium and Mozilla already behave as specified by this change, and the current behavior of WebKit (returning an empty @nmahendru or @annevk let me know if you have any objections. And @BenWiederhake thanks for your patience! |
github-actions bot
added a commit
that referenced
this pull request
Mar 7, 2025
SHA: 43f2f62 Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ciphertext is not a positive multiple of 16 bytes, return an
OperationError.Fixes #381.
Most implementations already return an
OperationErrorin this case, except Safari, which currently returns an emptyArrayBufferfor the test case in #381. @nmahendru let me know if this change seems reasonable to you.Preview | Diff