Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new landing page templates and navigation components with updated… #165

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ostafinskim
Copy link
Member

New navigation components and landing page templates with the updated logo.

@simonrjones
Copy link
Member

Published to the staging site, see Basecamp message: https://3.basecamp.com/3091560/buckets/32734213/messages/8134231991

This work is being reviewed by W3C, please don't merge it in at present.

@simonrjones simonrjones marked this pull request as draft December 17, 2024 10:32
@vivienlacourba
Copy link
Member

@simonrjones, @ostafinskim, FYI @jean-gui is starting to review this work.

For the changes related to deployer fixes as those have already been merged in the main branch, they should probably not be part of this MR anymore (maybe it simply needs to be rebased against main).

@jean-gui jean-gui force-pushed the feature/update-logo branch from b8d1284 to 65d7915 Compare January 10, 2025 11:00
@jean-gui
Copy link
Contributor

Hi @ostafinskim @simonrjones,

I have pushed a few changes to this PR:

We don't know yet which main logo to use. Once we know we can update all the templates accordingly and remove the two test pages from the design system.

The new style can be seen in action at https://www-dev.w3.org/.

I noticed that the main logo doesn't have a fixed size. It is smaller when logged in. It then seems to depend on the width of the "My account" block. This does not happen with the older version because the CSS specified a width and height, while the new one only has a max-width.

@ostafinskim
Copy link
Member Author

Hi @jean-gui,

Thank you for the recent changes and all the detailed updates!

I have edited the logo styles again and deployed the changes to the staging site for review.

Many thanks,

Copy link
Member

@sean-dunwoody sean-dunwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo currently has no spacing between it and the main navigation. This doesn't look right, and is more noticeable when the focus state is active on the first menu item:

Screenshot 2025-01-20 at 12 32 34
Screenshot 2025-01-20 at 12 32 29

This could be fixed by applying some right margin on the logo, or using the gap CSS property on the header flexbox container.

Beyond that the other changes look OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants