Update language for narrow type test. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigBlueHat
requested changes
Dec 12, 2023
Co-authored-by: BigBlueHat <byoung@digitalbazaar.com>
BigBlueHat
requested changes
Dec 12, 2023
tests/10-vcdm2.js
Outdated
| ' can process this additional information.', async function() { | ||
| 'SHOULD specify, or be associated with, additional more narrow types ' + | ||
| '(like ExampleDegreeCredential, for example) so software systems ' + | ||
| ' can more easily detect and process this additional information.', async function() { |
There was a problem hiding this comment.
Mind fixing the line length? Sorry about that...
There was a problem hiding this comment.
yeah length issues pop up a lot with the github comments will work on it in a moment.
There was a problem hiding this comment.
address here: 3f97008
BigBlueHat
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the narrow type test to a SHOULD