Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make definitions for System and its subclasses consistent #287

Open
wants to merge 13 commits into
base: gh-pages
Choose a base branch
from
Open

Make definitions for System and its subclasses consistent #287

wants to merge 13 commits into from

Conversation

dr-shorthair
Copy link
Collaborator

@dr-shorthair dr-shorthair linked an issue Mar 5, 2025 that may be closed by this pull request
Divergence between Sensor (Device, agent (including humans), or software (simulation)) and Actuator (device) #280
Open
@dr-shorthair dr-shorthair requested a review from ldesousa March 5, 2025 10:15
@dr-shorthair
Copy link
Collaborator Author

One more review required here: @ldesousa @oldskeptic @rob-metalinkage

rob-metalinkage
rob-metalinkage reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

@rob-metalinkage rob-metalinkage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - probably consistency with OMS is the key here though

ldesousa
ldesousa requested changes Mar 12, 2025
View reviewed changes
TallTed
TallTed reviewed Mar 12, 2025
View reviewed changes
dr-shorthair and others added 7 commits March 16, 2025 10:18
@dr-shorthair @TallTed
Update ssn/chapters/Actuation.html
6276744 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@dr-shorthair @TallTed
Update ssn/chapters/Common.html
485d2fe 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@dr-shorthair @TallTed
improve grammar Update ssn/rdf/ontology/core/sosa-observation.ttl
a175f88 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@dr-shorthair @TallTed
Improve grammar Update ssn/rdf/ontology/core/sosa-sampling.ttl
db127cd 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@dr-shorthair
Remove awkward parentheses
211063f
@dr-shorthair
Also make Execution definitions consistent
750bebd
@dr-shorthair
Align RDF and HTML with consistent defs for Systems and Executions
f7fddc0
@dr-shorthair
Copy link
Collaborator Author

parentheses removed
a vs an fixed
also made Execution defs consistent
RDF and HTML both contain the same defs

@dr-shorthair dr-shorthair requested a review from ldesousa March 17, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@rob-metalinkage rob-metalinkage rob-metalinkage left review comments

@maximelefrancois86 maximelefrancois86 maximelefrancois86 approved these changes

@ldesousa ldesousa Awaiting requested review from ldesousa

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Divergence between Sensor (Device, agent (including humans), or software (simulation)) and Actuator (device)
5 participants
@dr-shorthair @ldesousa @TallTed @rob-metalinkage @maximelefrancois86