Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compaction to @type map when the compacted item is not already a map. #611

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

gkellogg
Copy link
Member

The algorithm inspects compacted item to see if it has value for container key when compacted item is not a map.

From ruby-rdf/json-ld#62.

@BigBlueHat BigBlueHat merged commit 2e10884 into main Jan 15, 2025
1 check passed
@BigBlueHat BigBlueHat deleted the compact-container-type-with-iri branch January 15, 2025 17:46
@w3cbot
Copy link

w3cbot commented Jan 15, 2025

This was discussed during the #json-ld meeting on 15 January 2025.

View the transcript

w3c/json-ld-api#611

<gb> Pull Request 611 Add compaction to @type map when the compacted item is not already a map. (by gkellogg) [test:missing-coverage]

gkellogg: it is just an additional test.
… pchampin approved it

dlehn: should we use http: or https: for schema.org?

gkellogg: I think all our examples use http: for schema.org.

bigbluehat: this should be an orthogonal discussion. This does not really matter to this test specifically.
… Any objection to merging this?
… Hearing none.

merged that, btw


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Testing
Development

Successfully merging this pull request may close these issues.

4 participants