-
Notifications
You must be signed in to change notification settings - Fork 34
Error in fromRdf/0027-out.jsonld #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @marcelotto, thanks for looking into this!
I will prepare a PR, we will maybe discuss this on the next meeting. I was the one who wrote this test and I do remember that I was considering the two alternatives: value object vs a native JSON value and somehow I chose the former. I do not recall the details anymore. |
For reference, I think this is the PR #625 |
This was discussed during the #json-ld meeting on 09 April 2025. View the transcriptw3c/json-ld-api#648<gb> Issue 648 Error in fromRdf/0027-out.jsonld (by marcelotto) anatoly-scherbakov: when I was converting literals into JSON-LD <gb> Pull Request 650 #648 `0027-out.jsonld`: ` gkellogg: the first sentence was about ` anatoly-scherbakov: yes. exactly gkellogg: so the linked issue is 648 anatoly-scherbakov: and the PR is 650 gkellogg: thanks |
I double checked the (2) above. Check out RDF to Object conversion → Algorithm
There are no early returns between 2.1 and 2.11 which I can see. This indeed will be a value object. Test seems correct in that regard. Sorry for the confusion above. |
The new
fromRdf#t0027
test expects its result to be wrapped in a@graph
container. Maybe I'm missing something, but that seems wrong to me.Also: Why is the
@type
specified on the values of theboolean-native
object, when the corresponding values in the input are valid boolean values? Same onnumber-native
.The text was updated successfully, but these errors were encountered: