Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Convert a value to a key" should return invalid for detached array buffers #440

Merged
merged 4 commits into from
Feb 26, 2025
Merged

"Convert a value to a key" should return invalid for detached array buffers #440

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6723e4
Initial commit
SteveBeckerMSFT Feb 26, 2025
1dd4668
Fix newlines
SteveBeckerMSFT Feb 26, 2025
1c3af53
Make detached buffer check more specific. Updated revision history a…
SteveBeckerMSFT Feb 26, 2025
d7fc3fc
Use shorthand for arra buffer detached
SteveBeckerMSFT Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6366,9 +6366,11 @@ steps may throw an exception.
<!-- Binary -->
: If |input| is a [=buffer source type=]
::
1. If |input| is [[=BufferSource/detached=]] then return invalid.

1. Let |bytes| be the result of
[=/get a copy of the buffer source|getting a copy of the bytes held by the buffer source=]
|input|. Rethrow any exceptions.
|input|.

1. Return a new [=/key=] with [=key/type=]
*binary* and [=key/value=] |bytes|.
Expand Down Expand Up @@ -6717,6 +6719,7 @@ For the revision history of the second edition, see [that document's Revision Hi
* Used [[infra]]'s list sorting definition. (<#346>)
* Added a definition for [=transaction/live=] transactions, and renamed "run an upgrade transaction" to [=/upgrade a database=], to disambiguate "running". (<#408>)
* Specified the {{DOMException}} type for failures when reading a value from the underlying storage in [[#object-store-retrieval-operation]]. (<#423>)
* Updated [=convert a value to a key=] to return invalid for detached array buffers. (<#417>)

<!-- ============================================================ -->
# Acknowledgements # {#acknowledgements}
Expand Down Expand Up @@ -6787,6 +6790,7 @@ Pablo Castro,
Philip Jägenstedt,
Shawn Wilsher,
Simon Pieters,
Steve Becker,
Tobie Langel,
Victor Costan,
Xiaoqian Wu,
Expand Down