Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T7012 ospf_interfaces integration tests #387

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

T7012 ospf_interfaces integration tests #387

wants to merge 13 commits into from

Conversation

omnom62
Copy link
Contributor

@omnom62 omnom62 commented Feb 5, 2025 •
edited
Loading

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Test results

  • Sanity tests passed
  • Unit tests passed

Tested against VyOS versions:

  • 1.3.8
  • 1.4-rolling-202201010100

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the ansible sanity and unit tests
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added unit tests to cover my changes
  • I have added a file to changelogs/fragments to describe the changes

gaige
gaige requested changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@gaige gaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts and questions

tests/integration/targets/vyos_ospf_interfaces/vars/pre-v1_4.yaml Outdated Show resolved Hide resolved
tests/integration/targets/vyos_ospf_interfaces/tests/cli/_populate.yaml Outdated Show resolved Hide resolved
tests/integration/targets/vyos_ospf_interfaces/tests/cli/rtt.yaml Show resolved Hide resolved
@omnom62 omnom62 marked this pull request as ready for review February 10, 2025 20:34
@omnom62 omnom62 requested a review from a team as a code owner February 10, 2025 20:34
gaige
gaige requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@gaige gaige left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the minor change here is actually a bug fix, however, also add support for the 1.4+ move in the configuration as a minor_change.

changelogs/fragments/T7012_ospf-integration-tests.yaml Show resolved Hide resolved
@gaige gaige requested review from andamasov and removed request for vyosbot February 12, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaige gaige gaige requested changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/vyos-ansible-collection-maintainers

@andamasov andamasov Awaiting requested review from andamasov

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omnom62 @gaige