-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding filter argument to download_tableau_data function #8
Comments
That would indeed be useful! Could you check and get back to me whether the following function fits your needs?
I would then use it as follows:
|
Thanks @Tomeriko96 ! This looks great. My only recommendation would be to add something similar to the following two lines of code within the |
@chasebinns27 Excellent addition also! I gather the function then should look as follows:
|
@Tomeriko96 These edits look great to me. Thanks! |
Good! Commit 5d9456d introduced the changes mentioned in this issue. The changes are available on the development version of the package. In the coming weeks, I will look at the other methods of the package to add (optional) arguments, before submitting a new version to CRAN. Until the CRAN update, I will keep this issue open |
Hello, @Tomeriko96! Do you have an idea of when you plan to ship new updates to CRAN? Just asking for internal planning purposes for my company's use of |
Hello @benjaminrobinson , Unfortunately, we did not find time over summer to implement wrt adding optional arguments to existing functions. However, we certainly can submit the current state of the package to CRAN. |
Hi @benjaminrobinson |
It would be very helpful if a
filter
argument was added to thedownload_tableau_data
function to have better control over the view data being pulled. Ideally we could pass something likefilter = 'Year=2023'
in the function to only return 2023 view data, and then 'vf_Year=2023' would be included in the base_url.The text was updated successfully, but these errors were encountered: