Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data file path in createXSworkspace.py #46

Closed
ram1123 opened this issue Jun 13, 2022 · 0 comments · Fixed by #48
Closed

Update data file path in createXSworkspace.py #46

ram1123 opened this issue Jun 13, 2022 · 0 comments · Fixed by #48
Assignees
@ram1123 @qyguo
Labels
bug Something isn't working urgent
Milestone
First running ver...

Comments

@ram1123
Copy link
Collaborator

ram1123 commented Jun 13, 2022

Update the path of each year data in the module createXSworkspace.py

Fiducial_XS/python/createXSworkspace.py

Lines 567 to 568 in a19f308

if (obsName=="mass4lREFIT"): data_obs_file = TFile('Inputs/data_13TeV_refit.root')
else: data_obs_file = TFile('Inputs/data_13TeV.root') #FIXME: Want to keep this in Input directory or at the same place where all ntuples are stored

@ram1123 ram1123 added bug Something isn't working urgent labels Jun 13, 2022
@ram1123 ram1123 added this to the First running version of 2018 milestone Jun 13, 2022
@ram1123 ram1123 self-assigned this Jun 13, 2022
@ram1123 ram1123 pinned this issue Jun 13, 2022
@ram1123 ram1123 linked a pull request Jul 7, 2022 that will close this issue
Combine all Years #48
Merged
vukasinmilosevic pushed a commit that referenced this issue Jul 19, 2022
@ram1123 @qyguo
Combine all Years (#48)
6db51f4 
* - Added missing year option in template maker
- Added additional append lines for the command output txt files
- Added missing import of GetDirectory in the plotDifferentialBins.py

* new changes

* small bug update

* fix small bug

* nnlops

* partly change 125.0 To 125.38 to be updated

* update 125.38

* update

* issues updated

* fix

* update

* Added year in the combine output root files

* moved all combine outputs to the combineOutputs directory

* Better handling of combine root files (#40)

* Added year in the combine output root files

* moved all combine outputs to the combineOutputs directory

* Removed the hardcoded year value from combine output root files

* updated the use of datatcardDir and combineOutputs directory

* Updated condor script tar file skipping

* - First Running version of all three year combination
- Still need to add the plotting functionalities for the combined year.

* Removing unnecessary changes w.r.t. master branch

* minor fixes

* Cross-section and acc addition fix; need to take average when computing acc for three years

* UPdated lumi

* Updated data path (this will fix issue #46), and removed duplicate dict from module sample_shortnames

* Updated lumi

* Removed unnecessary line

* - Reading ntuple path from Load data
- Updated few instances of `if (obsName.startswith("mass4l")):` to if (obsName == "mass4l" ):
- Updated plotDifferentialBins.py script as per https://github.com/tjavaid/Fiducial_XS_combination/blob/main/plotDifferentialBins.py
- Added year to the instance where template XS was running related to #49
- Added JES info to datacard. Just reading the JES dict created using `read_jes` module and appending info at the end of datacard. Related to #49
- Updated year positon in the template maker function `fiducialXSTemplates`

* Fix the plotAsimov

* - Updated print out label from debug to ERROR
- Added print statements inside if conditions (if DEBUG) in interpolation module
- Updated lumi access in plotAsimov module

Co-authored-by: qianying guo <qyguo@buaa.edu.cn>
vukasinmilosevic pushed a commit that referenced this issue Jul 22, 2022
@ram1123
Updated data path (this will fix issue #46), and removed duplicate di…
a08c557 
…ct from module sample_shortnames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ram1123 ram1123

@qyguo qyguo

Labels
bug Something isn't working urgent
Projects
None yet
Milestone
First running version of 2018
Development

Successfully merging a pull request may close this issue.

Combine all Years ram1123/Fiducial_XS
2 participants
@ram1123 @qyguo