Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change anyOf to oneOf in rule schemas to make intent clearer #2663

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Change anyOf to oneOf in rule schemas to make intent clearer #2663

merged 1 commit into from
Jan 5, 2025
+15 −15

Conversation

FloEdelmann
Copy link
Member

See https://ajv.js.org/json-schema.html#oneof:

The data is valid if it matches exactly one JSON Schema from this array.

See https://ajv.js.org/json-schema.html#anyof:

The data is valid if it is valid according to one or more JSON Schemas in this array.

waynzh
waynzh approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@waynzh waynzh merged commit 9d8f2de into master Jan 5, 2025
18 checks passed
@waynzh waynzh deleted the any-of-one-of branch January 5, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynzh waynzh waynzh approved these changes

@ota-meshi ota-meshi Awaiting requested review from ota-meshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @waynzh