feat: create textarea component #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
artursantiago
requested review from
hellofanny and
pedromtec
and removed request for
a team
artursantiago
force-pushed
the
feat/add-textarea-component
branch
from
d461961 to
ae081dd
Compare
2 tasks
Guilera
force-pushed
the
feat/add-textarea-component
branch
from
71f3b76 to
007b065
Compare
pedromtec
reviewed
Feb 17, 2025
hellofanny
approved these changes
Feb 17, 2025
|
todo: I'll request doc for education after merging - new Component (Textarea) |
|
@pedromtec I'll merge this one ok? |
pedromtec
approved these changes
Feb 17, 2025
|
@mariana-caetano Doc request for new component |
hellofanny
added a commit
that referenced
this pull request
Feb 18, 2025
>⚠️ THIS PR DEPENDS ON [PR#2640](#2640)⚠️ ## What's the purpose of this pull request? This pull request adds the TextareaField atom component based on the InputField component. This component will be used in the form of the modal for adding a review to a product in the new Reviews and Ratings section. ## How does it work? This PR introduces the `TextareaField` molecule component, which extends the functionality of the `Textarea` component. It accepts additional props such as `id`, `label`, `error`, and `disabled`, alongside all the standard props of the `Textarea` component. The `TextareaField` uses the `Textarea` component internally. One thing to pay attention in this implementation is related to the label used in the add new review form. In the Figma design, the label text is very long, which could either exceed the width of the `Textarea` or break into multiple lines, overlapping the text area. To solve this, I added a logic using a `useEffect` hook to dynamically calculate the width of the `Textarea` and set it as the `max-width` of the label. Additionally, the `text-overflow: ellipsis` style is applied to truncate the label text if it exceeds the defined width. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-chore-add-textareafield-cli-vtex.vercel.app/review-and-ratings-playground) ## References [JIRA TASK: SFS-2076](https://vtex-dev.atlassian.net/browse/SFS-2076) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=0rv1XYm6XsgBeDwA-4)  --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This pull request adds the Textarea atom component based on the Input component. This component will be used in the form of the modal for adding a review to a product in the new Reviews and Ratings section.
How does it work?
This PR introduces the
Textareaatom component. In addition to the standard properties, it includes aresizeprop, which defaults toboth.The styling of the
Textareacomponent is based on the existingInputcomponent to maintain visual consistency.How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2075
Figma