Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize local cache and Change Min number of replicas #484

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

salesfelipe
Copy link
Contributor

What problem is this solving?

  • ditto.

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

To better understand the cache needs we can take a look at the number of disposed items

Screenshot 2025-01-29 at 14 56 44

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@salesfelipe salesfelipe added the enhancement New feature or request label Jan 29, 2025
@salesfelipe salesfelipe self-assigned this Jan 29, 2025
@salesfelipe salesfelipe requested a review from a team as a code owner January 29, 2025 17:57
@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 29, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

vtex-io-ci-cd bot commented Jan 29, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@@ -17,10 +17,10 @@ const NINE_SECONDS_MS = 9 * 1000

// Segments are small and immutable.
const segmentCache = new LRUCache<string, Cached>({ max: 1000 })
const searchCache = new LRUCache<string, Cached>({ max: 3000 })
const searchCache = new LRUCache<string, Cached>({ max: 6000 })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we recently made the pod bigger we can safely increase the size of this cache because we have a lot of room to grow.

const messagesCache = new LRUCache<string, Cached>({ max: 3000 })
const vbaseCache = new LRUCache<string, Cached>({ max: 3000 })
const appsCache = new LRUCache<string, Cached>({ max: 3000 })
const appsCache = new LRUCache<string, Cached>({ max: 1500 })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have no disposed items, we can try to reduce the size of it...

@salesfelipe salesfelipe merged commit a3642da into v1.x Feb 4, 2025
10 of 13 checks passed
@salesfelipe salesfelipe deleted the chore/changeCache branch February 4, 2025 14:43
Copy link

vtex-io-ci-cd bot commented Feb 4, 2025

Your PR has been merged! App is being published. 🚀
Version 1.74.0 → 1.75.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search-resolver@1.75.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants