-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize local cache and Change Min number of replicas #484
Conversation
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
@@ -17,10 +17,10 @@ const NINE_SECONDS_MS = 9 * 1000 | |||
|
|||
// Segments are small and immutable. | |||
const segmentCache = new LRUCache<string, Cached>({ max: 1000 }) | |||
const searchCache = new LRUCache<string, Cached>({ max: 3000 }) | |||
const searchCache = new LRUCache<string, Cached>({ max: 6000 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we recently made the pod bigger we can safely increase the size of this cache because we have a lot of room to grow.
const messagesCache = new LRUCache<string, Cached>({ max: 3000 }) | ||
const vbaseCache = new LRUCache<string, Cached>({ max: 3000 }) | ||
const appsCache = new LRUCache<string, Cached>({ max: 3000 }) | ||
const appsCache = new LRUCache<string, Cached>({ max: 1500 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have no disposed items, we can try to reduce the size of it...
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
How should this be manually tested?
Workspace
Checklist/Reminders
README.md
.CHANGELOG.md
.Screenshots or example usage
To better understand the cache needs we can take a look at the number of disposed items
Type of changes
Notes