Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: b2b seller quotes comments #71

Merged
merged 18 commits into from
Jan 27, 2025

Conversation

Matheus-Aguilar
Copy link
Contributor

What problem is this solving?

This pull request adds the fixes done by this one.

Disable section comments only on creation of a splitted quote.

How to test it?

  • Create a quote with products from a seller than accepts quotes and products from marketplace. The notes should be disabled on creation and a help text warning should be displayed. On view the created quote, the notes should be enabled.

Workspace

Screenshots

Disabled on creation:

image

Enabled on view created quote:

image

Copy link

vtex-io-ci-cd bot commented Jan 27, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 27, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Jan 27, 2025

Warnings
⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 72, PR deletions = 46

Generated by 🚫 dangerJS against 77a58c7

@Matheus-Aguilar Matheus-Aguilar changed the title Fix/b2 bteam 1998 b2b seller quotes fix: b2b seller quotes comments Jan 27, 2025
@Matheus-Aguilar Matheus-Aguilar merged commit 01ffb89 into master Jan 27, 2025
15 of 16 checks passed
@Matheus-Aguilar Matheus-Aguilar deleted the fix/B2BTEAM-1998-b2b-seller-quotes branch January 27, 2025 17:31
Copy link

vtex-io-ci-cd bot commented Jan 27, 2025

Your PR has been merged! App is being published. 🚀
Version 1.7.0 → 1.7.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-quotes@1.7.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants