Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paging support to getSellers query #168

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

icaroov
Copy link
Contributor

@icaroov icaroov commented Jul 30, 2024

What problem is this solving?

The getSellersPaginated query now accepts a paging input parameter, allowing the client to specify the range of sellers to retrieve. The response includes a paging object with information about the total number of sellers and the range of sellers returned. This change improves the flexibility and efficiency of retrieving seller data.

How to test it?

query GetSellersPaginated($page: Int, $pageSize: Int) {
  getSellersPaginated(page: $page, pageSize: $pageSize) {
    pagination {
      page
      pageSize
      total
    }
    items {
      id
      name
      email
    }
  }
}

How does this PR make you feel? 🔗

The `getSellers` query now accepts a `paging` input parameter, allowing the client to specify the range of sellers to retrieve. The response includes a `paging` object with information about the total number of sellers and the range of sellers returned. This change improves the flexibility and efficiency of retrieving seller data.
Copy link

vtex-io-ci-cd bot commented Jul 30, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Jul 31, 2024

Warnings
⚠️

package.json was changed, but not yarn.lock (vice-versa) [:bulb: are you sure this is right?]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 158, PR deletions = 4

Generated by 🚫 dangerJS against 370a687

node/resolvers/Queries/Settings.ts Outdated Show resolved Hide resolved
graphql/schema.graphql Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
@icaroov icaroov requested a review from enzomerca July 31, 2024 17:46
graphql/schema.graphql Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
node/resolvers/Queries/Settings.ts Outdated Show resolved Hide resolved
@icaroov icaroov requested a review from enzomerca August 5, 2024 18:54
graphql/schema.graphql Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
@icaroov icaroov requested a review from enzomerca August 6, 2024 14:48
node/clients/sellers.ts Outdated Show resolved Hide resolved
node/clients/sellers.ts Outdated Show resolved Hide resolved
@icaroov icaroov requested a review from enzomerca August 7, 2024 14:07
Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I will do some tests later but we should merge/deploy this change next week!

Copy link

sonarqubecloud bot commented Aug 7, 2024

@enzomerca enzomerca merged commit 4883562 into vtex-apps:master Aug 12, 2024
20 of 21 checks passed
Copy link

vtex-io-ci-cd bot commented Aug 12, 2024

Your PR has been merged! App is being published. 🚀
Version 0.53.0 → 0.54.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-organizations-graphql@0.54.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants