-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add retry to sendMetric to avoid connection errors #145
fix: add retry to sendMetric to avoid connection errors #145
Conversation
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
@@ -1,6 +1,8 @@ | |||
import axios from 'axios' | |||
|
|||
const ANALYTICS_URL = 'https://rc.vtex.com/api/analytics/schemaless-events' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, apparently "normal" IO apps do not have access to analytics.vtex.com
, only IO Infra apps.
We decided to keep this URL for now and if we keep seeing errors, we can reachout to #analytics-support and see what can be done.
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
We are currently seeing a lot of
Error to send metrics from auth metric
on opensearch logs with the following details:This PR adds retries to this post call to mitigate connection errors.
How to test it?
Change an organization detail on admin and check a metric for updating organization is sent
Workspace