Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyrings for apt sources on Debian/Ubuntu #1629

Open
xolyu opened this issue Feb 11, 2025 · 1 comment
Open

Use keyrings for apt sources on Debian/Ubuntu #1629

xolyu opened this issue Feb 11, 2025 · 1 comment

Comments

@xolyu
Copy link

xolyu commented Feb 11, 2025

Use nginx's official key https://nginx.org/keys/nginx_signing.key instead of hardcoded key ID with deprecated apt-key method.

nginx's maintainer will rotate PGP keys every two years:

Going forward, we will rotate the PGP signing key every two years.
(source)

So, it would be better to use key URL with keyring infrastructure instead of a regularly expiring key that is hardcoded with it's ID in this repository and is not updated quickly.

That would also solve #1624


https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/package/debian.pp#L34

@xolyu
Copy link
Author

xolyu commented Feb 11, 2025

There is already a pull request, but not merged, yet.

#1610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant