more options to get_values_optimize, get_mu_and_sigma, speckle_noise_uncertainty. typo & docstring fixes #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a and they are in algo_options
# Conflicts: # vip_hci/fm/negfc_fmerit.py # vip_hci/fm/utils_negfc.py
|
Thanks a lot @IainHammond |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request just allows for a few more parameters related to full frame and annular PCA to be provided to
get_values_optimizeandget_mu_and_sigma, such asdelta_rot,radius_int,source_xy,asizeandmask_rdi, by including them in thealgo_optionsparameter. This also applies tospeckle_noise_uncertainty, whereannulus_widthanddelta_rotcan be provided.There are also some other small quality-of-life improvements like typo fixes and more informative error messages.