Migrate CSV data to DatoCMS #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siilwyn
commented
Oct 25, 2023
Siilwyn
commented
Oct 25, 2023
✅ Deploy Preview for spacefinder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Siilwyn
force-pushed
the
csv-chips
branch
3 times, most recently
from
a90a84b to
b03238c
Compare
Siilwyn
changed the title
Siilwyn
commented
Oct 27, 2023
Comment on lines
+68
to
+70
| <ClientOnly fallback="..."> | ||
| {{ spacesStore.numberOfSelectedFilters }} | ||
| </ClientOnly> |
There was a problem hiding this comment.
Unrelated to changes but fixes some hydration errors, I disagree with https://github.com/voorhoede/tudelft-spacefinder/blob/master/docs/decision-log/2023-05-02-not-fixing-hydration-warnings.md ;)
Siilwyn
commented
Oct 27, 2023
| :opening-hours-space="building.openingHours" | ||
| class="building-header__opening-hours" | ||
| /> | ||
| <ClientOnly> |
There was a problem hiding this comment.
Same as above, fixes hydration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.