Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of Docker compose #12

Open
yashpandey06 opened this issue Feb 2, 2025 · 5 comments
Open

Introduction of Docker compose #12

yashpandey06 opened this issue Feb 2, 2025 · 5 comments

Comments

@yashpandey06
Copy link

Description

Enhance the project by introducing Docker Compose to simplify service orchestration and deployment. This will allow contributors and users to set up the development environment more easily with a single command.

Expected Outcome

  • Running docker-compose up should start all required services seamlessly.
  • The application should be accessible at the appropriate ports.
  • Clear documentation should guide users on setup and troubleshooting.
@Monokaix
Copy link
Member

Monokaix commented Feb 5, 2025

That's a good idea!

@Sayan4444
Copy link

Hi I had a confusion. Are we creating docker-compose.yml for development purpose? Like we hit docker compose up and all services start with hot reloading enabled?

If yes I guess we should write a new Dockerfile.yml for the both frontend and backend.The pre-written docker images are mainly for kubernetes deployment.

What I personally feel for local development, adding a simple script which starts first volcano, then both frontend and backend should be more efficient with properly written README would be better. Do tell me your thoughts

@yashpandey06
Copy link
Author

I am making it specifically for local dev also and prod also ...industry practice is to have both in repos .

@Sayan4444
Copy link

Sayan4444 commented Feb 5, 2025

Oh I get it, instead of deploying the docker images in k8s using volcano-dashboard.yaml, it will run individually started using docker-compose for PROD.

@Monokaix
Copy link
Member

Monokaix commented Feb 7, 2025

The dashaboard uses InClusterConfig to access kube-apiserver, so you can also deploy it in a deveploment cluster to develop locally, and if you want to use docker-compose, maybe we should add a flag like #9 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants