🌱 Do deployment rollout when capabilities change #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/jitter-exit-on-caps
branch
6 times, most recently
from
b957ad7 to
eb246d9
Compare
github-actions
bot
added
size/XL
akutz
force-pushed
the
feature/jitter-exit-on-caps
branch
3 times, most recently
from
016f39b to
3e99fb5
Compare
akutz
changed the title
akutz
force-pushed
the
feature/jitter-exit-on-caps
branch
from
3e99fb5 to
cbd3dbe
Compare
bryanv
reviewed
Feb 10, 2025
controllers/infra/capability/configmap/configmap_capability_controller.go
Show resolved
Hide resolved
akutz
force-pushed
the
feature/jitter-exit-on-caps
branch
from
cbd3dbe to
e1daecd
Compare
This patch changes the behavior of how the pod is exited when the capabilities have changed. Instead of all the replicas exiting at the same time, the exits are managed by causing the pod's deployment to rollout a new set of pods. This ensures that at least one pod is always online to respond to webhook requests. This patch also ensures the capabilities controllers are run only on the leader.
akutz
force-pushed
the
feature/jitter-exit-on-caps
branch
from
e1daecd to
c9069e8
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch changes the behavior of how the pod is exited when the capabilities have changed. Instead of all the replicas exiting at the same time, the exits are managed by causing the pod's deployment to rollout a new set of pods.
This ensures that at least one pod is always online to respond to webhook requests.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please note that eventually I want to change the behavior such that the leader is responsible for terminating the other replicas to ensure another pod is up before the leader exits. This PR is a half-step that makes things better than they are today.Please add a release note if necessary: