🐛 Fix missing labels on CVMI resources #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
fix/missing-label-on-cvmi
branch
2 times, most recently
from
e5169b3 to
4be5413
Compare
bryanv
approved these changes
Jan 28, 2025
akutz
force-pushed
the
fix/missing-label-on-cvmi
branch
from
4be5413 to
00b00e3
Compare
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via vmware-tanzu#406 but were accidentally removed via vmware-tanzu#851. When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
akutz
force-pushed
the
fix/missing-label-on-cvmi
branch
from
00b00e3 to
ca12dd7
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via #406 but were accidentally removed via #851.
When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: