Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Increase CPU and memory limits for the controller manager pod #869

Merged
merged 1 commit into from
Jan 24, 2025
Merged

🌱 Increase CPU and memory limits for the controller manager pod #869

merged 1 commit into from
Jan 24, 2025

Conversation

aruneshpa
Copy link
Contributor

What does this PR do, and why is it needed?

This change increases the CPU and memory limits for the controller manager pod in VM operator deployment to support the desired scale for VCF 9.0.

Testing Done:

  • Generated the manifest and verified that the CPU and memory limits were updated:
          limits:
            cpu: 1500m
            memory: 1Gi
          requests:
            cpu: 100m
            memory: 75Mi

Please add a release note if necessary:

Increase CPU and memory limits for the controller manager pod

@aruneshpa
Increase CPU and memory limits for the controller manager pod
7c084d2 
This change increases the CPU and memory limits for the controller
manager pod in VM operator deployment to support the desired scale for
VCF 9.0.

Testing Done:
- Generated the manifest and verified that the CPU and memory limits
were updated:
```
          limits:
            cpu: 1500m
            memory: 1Gi
          requests:
            cpu: 100m
            memory: 75Mi
```
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 24, 2025
@aruneshpa aruneshpa changed the title :sapling: Increase CPU and memory limits for the controller manager pod 🌱 Increase CPU and memory limits for the controller manager pod Jan 24, 2025
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem 100% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem 100% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/configmap 86% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/crd 93% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap 71% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/node 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/secret 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/validatingwebhookconfiguration 85% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/zone 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/storageclass 95% ✔
github.com/vmware-tanzu/vm-operator/controllers/storagepolicyquota 97% ✔
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/storagepolicyusage 98% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/virtualmachine 69% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volume 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass 75% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineimagecache 89% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice 83% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy 82% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/bitmask 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/builder 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/conditions 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/config 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/capabilities 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/env 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context/generic 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context/operation 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/errors 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/mem 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/client 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary 72% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session 71% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/storage 44% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/sysprep 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine 84% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle 62% ❌
github.com/vmware-tanzu/vm-operator/pkg/record 87% ➖
github.com/vmware-tanzu/vm-operator/pkg/topology 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/image 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 89% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/kube/cource 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/proxyaddr 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/kube/spq 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/netplan 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/paused 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ptr 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize 97% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 81% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client 64% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/library 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 79% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/watcher 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/crypto 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 100% ✔
github.com/vmware-tanzu/vm-operator/services/vm-watcher 93% ✔
github.com/vmware-tanzu/vm-operator/webhooks/common 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/unifiedstoragequota/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation 87% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation 62% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation 89% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation 67% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/validation 92% ✔
Summary 82% (11321 / 13746) ➖

Minimum allowed line rate is 79%

@aruneshpa aruneshpa merged commit 123d5bd into vmware-tanzu:main Jan 24, 2025
10 checks passed
@aruneshpa aruneshpa deleted the increase-resource-limits-for-vcf-9-0 branch January 24, 2025 21:35
akutz pushed a commit to akutz/vm-operator that referenced this pull request Feb 6, 2025
@aruneshpa @akutz
Increase CPU and memory limits for the controller manager pod (vmware…
c5e8417 
…-tanzu#869)

This change increases the CPU and memory limits for the controller
manager pod in VM operator deployment to support the desired scale for
VCF 9.0.

Testing Done:
- Generated the manifest and verified that the CPU and memory limits
were updated:
```
          limits:
            cpu: 1500m
            memory: 1Gi
          requests:
            cpu: 100m
            memory: 75Mi
```
@akutz akutz mentioned this pull request Feb 6, 2025
Merged
akutz pushed a commit to akutz/vm-operator that referenced this pull request Feb 6, 2025
@aruneshpa @akutz
Increase CPU and memory limits for the controller manager pod (vmware…
1da7492 
…-tanzu#869)

This change increases the CPU and memory limits for the controller
manager pod in VM operator deployment to support the desired scale for
VCF 9.0.

Testing Done:
- Generated the manifest and verified that the CPU and memory limits
were updated:
```
          limits:
            cpu: 1500m
            memory: 1Gi
          requests:
            cpu: 100m
            memory: 75Mi
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akutz akutz akutz approved these changes

@bryanv bryanv bryanv approved these changes

Assignees
No one assigned
Labels
cla-not-required size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aruneshpa @akutz @bryanv @vmwclabot