-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add docs for CD-ROM and ISO VM deployment workflow #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ab7f67
to
35f3904
Compare
akutz
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some notes if you want to tackle them now or later. Thanks @dilyar85 !
35f3904
to
c98c2cf
Compare
b55bec6
to
a6b2d8f
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This PR adds the long-overdue docs for the
vm.spec.cdrom
field introduced in the v1alpha3 API, as well as a tutorial page for importing ISO images from URL, deploying VM from ISO, and configuring guest OS installation using web console.Which issue(s) is/are addressed by this PR?
Fixes N/A.
Are there any special notes for your reviewer:
None.
Please add a release note if necessary:
📚 Documentation preview 📚: https://vm-operator--843.org.readthedocs.build/en/843/