🌱 Rename the pause-reconcile annotation to paused #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruneshpa
force-pushed
the
feature/rename-pause-annotation
branch
from
40d4a09 to
90d5ddd
Compare
|
I did realize a concern last night -- will this be confused with a VM being paused as in being in a suspended state? |
I think this should be fine since the suspended state is conveyed through spec and status. It also helps that this is clearly called out in the API docs. |
|
@bryanv and @akutz , the tricky thing I want to call out is, after this change, I am proactively removing the label that doesn't correspond to the destination schema version. For example, if a v1a3 VM was created with both "pause-reconcile" and "paused" annotations, and this resource is fetched at v1a2, the conversion logic will drop the "paused" annotation from the resource (which the user had explicitly applied). |
bryanv
reviewed
Jul 23, 2024
I don't think that will be a big deal for this annotation. Note though that we do have the hub version stashed away in the annotation so if we really wanted/needed to we could restore it. |
aruneshpa
force-pushed
the
feature/rename-pause-annotation
branch
from
90d5ddd to
58b4b72
Compare
bryanv
reviewed
Aug 22, 2024
bryanv
approved these changes
Aug 22, 2024
This change renames the "pause-reconcile" annotation used to pause the reconciliation of a VM to "paused". This is consistent with other components using "paused" to indicate an entity being paused. Additionally, introduce a helper package that can be used to check if an annotation is present (regardless of the value) in a readable way.
aruneshpa
force-pushed
the
feature/rename-pause-annotation
branch
from
58b4b72 to
c6cfb8d
Compare
Minimum allowed line rate is |
dougm
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This change renames the "pause-reconcile" annotation used to pause the reconciliation of a VM to "paused". This is consistent with other components using "paused" to indicate an entity being paused.
Additionally, introduce a helper package that can be used to check if an annotation is present (regardless of the value) in a readable way.
Testing Done:
pausedannotation set.pause-reconcileannotation setpause-reconcileannotation is set.Please add a release note if necessary: