Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable unnecessary-stmt from revive #8673

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 8, 2025

Thank you for contributing to Velero!

Please add a summary of your change

enable unnecessary-stmt from revive

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 8, 2025
@mmorel-35 mmorel-35 marked this pull request as ready for review February 8, 2025 10:44
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.39%. Comparing base (0bf2252) to head (9010d9b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/resourcemodifiers/strategic_merge_patch.go 0.00% 3 Missing ⚠️
pkg/plugin/framework/common/client_errors.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8673      +/-   ##
==========================================
+ Coverage   59.37%   59.39%   +0.02%     
==========================================
  Files         370      370              
  Lines       39989    39988       -1     
==========================================
+ Hits        23744    23752       +8     
+ Misses      14752    14744       -8     
+ Partials     1493     1492       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the revive/unnecessary-stmt branch from 69fd366 to 9010d9b Compare February 8, 2025 12:11
@kaovilai kaovilai merged commit 5d9a4e8 into vmware-tanzu:main Feb 10, 2025
41 of 42 checks passed
@mmorel-35 mmorel-35 deleted the revive/unnecessary-stmt branch February 10, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants