Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSL deletion/bucket-change should result in Backup CR deletion of completed backups #8661

Open
kaovilai opened this issue Jan 31, 2025 · 0 comments

Comments

@kaovilai
Copy link
Member

kaovilai commented Jan 31, 2025

Describe the problem/challenge you have

When BSL (bucketA) is deleted, associated completed backup CR remains on cluster.
It is possible to create BSL of the same name to a different bucketB containing a velero backup of the same name.
When Backup CR (created/stored on bucketA) is deleted when BSL is already pointing to bucketB, it should not delete backup1 on bucketB.

Describe the solution you'd like

Velero should delete completed Backup CRs when associated BSL object store bucket is changed or BSL is deleted from cluster.
If backup of the same name exists in bucketB, it will later be resync to cluster using existing backup sync controller with appropriate specs from bucketB.

Failed backups where results are not uploaded to bucket may remain in cluster for debugging.

Anything else you would like to add:

Alternative would be to store relevant parts of BSL spec in a backup annotation/status in a way that will prevent the problem described.

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant