Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document change to update known issue. #560

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

lipingxue
Copy link
Collaborator

What this PR does / why we need it:
This change is to update

  1. known issue: document the issue when specify VC using IPv6 address in "vsphere-csi.conf" when deploying the plugin and the workaround to this issue
  2. In TKGm env, user need to exclude the resources in the block list for backup/restore to avoid "Partially Failed" error.
    Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Liping Xue <lipingx@vmware.com>
@lipingxue lipingxue requested a review from xing-yang November 9, 2023 22:17
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/848/

docs/known_issues.md Outdated Show resolved Hide resolved
Signed-off-by: Liping Xue <lipingx@vmware.com>
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/849/

1 Outdated Show resolved Hide resolved
2 Outdated Show resolved Hide resolved
set-unit-env.sh Outdated Show resolved Hide resolved
Signed-off-by: Liping Xue <lipingx@vmware.com>
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/850/

Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lipingxue lipingxue merged commit b5cac82 into vmware-tanzu:main Nov 15, 2023
lipingxue added a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request Mar 11, 2024
* Document change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Remove files that are not needed for this change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

---------

Signed-off-by: Liping Xue <lipingx@vmware.com>
lipingxue added a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request Mar 11, 2024
* Document change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Remove files that are not needed for this change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

---------

Signed-off-by: Liping Xue <lipingx@vmware.com>
lipingxue added a commit that referenced this pull request Mar 11, 2024
* Update support matrix for Vanilla, WCP and GC. (#559)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Document change to update known issue. (#560)

* Document change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Remove files that are not needed for this change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

---------

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#562)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update document. (#566)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Modify parsing behavior of login credentials to handle Go escape characters (#564)

* Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

Create common config and new function to parse config data

* Always populate "port" key of parameters map after setting default VC port if config port value is empty

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Clean up test logging and unit tests

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Keep only necessary config values

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Refactor ParseConfig to return error for sanitized error handling

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

---------

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Only skip PVC creation if --namespace-mapping flag is not used (#565)

* Only skip PVC creation if --namespace-mapping flag is not used

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Refactor SkipPVCCreation function signature to add target namespace as a parameter

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

---------

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Add doc that wffc is not supported (#567)

Signed-off-by: xing-yang <xingyang105@gmail.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Fail the Restore if the StorageClass is associated with WaitForFirstConsumer volumeBindingMode (#568)

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
Co-authored-by: Deepak Kinni <dkinni@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

---------

Signed-off-by: Liping Xue <lipingx@vmware.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Varun Srinivasan <varuns6@vmware.com>
Signed-off-by: xing-yang <xingyang105@gmail.com>
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Varun Srinivasan <varun.srinivasan@broadcom.com>
Co-authored-by: Xing Yang <xingyang105@gmail.com>
Co-authored-by: Deepak Kinni <deepak.kinni@broadcom.com>
Co-authored-by: Deepak Kinni <dkinni@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants