-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add container image build ci #64
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
name: 'image' | ||
# This is a docker build check and publish job: | ||
# 1. PR Triggered docker image build check | ||
# - is for image build check | ||
# - Enable on main/*-dev branch | ||
# - push: ${{ github.event_name != 'pull_request' }} ==> false | ||
# 2. branches push trigger image publish | ||
# - is for branch/dev/nightly image | ||
# - commits are merge into main/*-dev ==> vllm-ascend:main / vllm-ascend:*-dev | ||
# 3. tags push trigger image publish | ||
# - is for final release image | ||
# - Publish when tag with v* (pep440 version) ===> vllm-ascend:v1.2.3|latest / vllm-ascend:v1.2.3rc1 | ||
on: | ||
pull_request: | ||
branches: | ||
- 'main' | ||
- '*-dev' | ||
paths: | ||
- '.github/workflows/image.yml' | ||
- 'Dockerfile' | ||
- 'vllm_ascend/**' | ||
push: | ||
# Publish image when tagging, the Dockerfile in tag will be build as tag image | ||
branches: | ||
- 'main' | ||
- '*-dev' | ||
tags: | ||
- 'v*' | ||
Yikun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
paths: | ||
- '.github/workflows/image.yml' | ||
- 'Dockerfile' | ||
- 'vllm_ascend/**' | ||
jobs: | ||
|
||
build: | ||
name: vllm-ascend image | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Prepare | ||
run: | | ||
REPO_OWNER=$(echo "${{ github.repository_owner }}" | tr '[:upper:]' '[:lower:]') | ||
echo "REPO_OWNER=${REPO_OWNER}" >> "$GITHUB_ENV" | ||
|
||
- name: Print | ||
run: | | ||
echo "REPO_OWNER:""${REPO_OWNER}" | ||
|
||
- name: Docker meta | ||
id: meta | ||
uses: docker/metadata-action@v5 | ||
with: | ||
# TODO(yikun): add more hub image and a note on release policy for container image | ||
# The REPO_OWNER will be: | ||
# - `vllm-project` in usptream repo | ||
# - lowercase github user in your fork repo | ||
images: | | ||
ghcr.io/${{ env.REPO_OWNER }}/vllm-ascend | ||
# Note for test case | ||
# https://github.com/marketplace/actions/docker-metadata-action#typeref | ||
# 1. branch job pulish per main/*-dev branch commits | ||
# 2. main and dev pull_request is build only, so the tag pr-N is fine | ||
# 3. only pep440 matched tag will be published: | ||
# - v0.7.1 --> v0.7.1, latest | ||
# - pre/post/dev: v0.7.1rc1/v0.7.1rc1/v0.7.1rc1.dev1/v0.7.1.post1, no latest | ||
# which follow the rule from vLLM with prefix v | ||
# TODO(yikun): the post release might be considered as latest release | ||
tags: | | ||
type=ref,event=branch | ||
type=ref,event=pr | ||
type=pep440,pattern={{raw}} | ||
|
||
- name: Free up disk space | ||
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1 | ||
with: | ||
tool-cache: true | ||
docker-images: false | ||
|
||
- name: Build - Set up QEMU | ||
uses: docker/setup-qemu-action@v2 | ||
# TODO(yikun): remove this after https://github.com/docker/setup-qemu-action/issues/198 resolved | ||
with: | ||
image: tonistiigi/binfmt:qemu-v7.0.0-28 | ||
|
||
- name: Build - Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v2 | ||
|
||
- name: Publish - Login to GitHub Container Registry | ||
uses: docker/login-action@v2 | ||
with: | ||
registry: ghcr.io | ||
username: ${{ github.actor }} | ||
password: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Build and push | ||
uses: docker/build-push-action@v6 | ||
with: | ||
platforms: linux/amd64,linux/arm64 | ||
cache-from: type=gha | ||
cache-to: type=gha,mode=max | ||
# only trigger when tag, branch/main push | ||
push: ${{ github.event_name != 'pull_request' }} | ||
labels: ${{ steps.meta.outputs.labels }} | ||
tags: ${{ steps.meta.outputs.tags }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image build will work even a pull_request is created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, only build check without push, see the ci results in current PR.
push: ${{ github.event_name != 'pull_request' }}
otherwise, we can guarantee the docker quality, but need 30 mins to check.
the whole workflow is