-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add container image build ci #64
Conversation
d8ae31f
to
297a1c9
Compare
fd49262
to
2a8597e
Compare
abe5458
to
8bd6077
Compare
name: 'image' | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image build will work even a pull_request is created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, only build check without push, see the ci results in current PR.
push: ${{ github.event_name != 'pull_request' }}
otherwise, we can guarantee the docker quality, but need 30 mins to check.
the whole workflow is
- first PR check
- then auto publish branch dev image for each commits
- auto publish final image when tag
name: 'image' | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, only build check without push, see the ci results in current PR.
push: ${{ github.event_name != 'pull_request' }}
otherwise, we can guarantee the docker quality, but need 30 mins to check.
the whole workflow is
- first PR check
- then auto publish branch dev image for each commits
- auto publish final image when tag
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
I think it's ready to go, after this PR merged:
|
Let's monitor the results:
|
### What this PR does / why we need it? Backport #64 to v0.7.1-dev branch Add container image build ci: - Enable branch, tag docker image publish - branch image: `vllm-ascend:main`, `vllm-ascend:v0.7.1-dev` - tag image: `vllm-ascend:v0.7.1rc1` - Enable PR docker image build check - other changes: - Prepare the `REPO_OWNER` because the ghcr lowerercase required - Add `Free up disk space` step to avoid `No space left on device` like #27 - Setup qemu with image to resolve docker/setup-qemu-action#198 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? build: CI passed --------- Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
### What this PR does / why we need it? Backport vllm-project#64 to v0.7.1-dev branch Add container image build ci: - Enable branch, tag docker image publish - branch image: `vllm-ascend:main`, `vllm-ascend:v0.7.1-dev` - tag image: `vllm-ascend:v0.7.1rc1` - Enable PR docker image build check - other changes: - Prepare the `REPO_OWNER` because the ghcr lowerercase required - Add `Free up disk space` step to avoid `No space left on device` like vllm-project#27 - Setup qemu with image to resolve docker/setup-qemu-action#198 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? build: CI passed --------- Signed-off-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: angazenn <zengyanjia@huawei.com>
What this PR does / why we need it?
Add container image build ci:
vllm-ascend:main
,vllm-ascend:v0.7.1-dev
vllm-ascend:v0.7.1rc1
REPO_OWNER
because the ghcr lowerercase requiredFree up disk space
step to avoidNo space left on device
like 有直接可用的容器镜像吗? #27tonistiigi/binfmt:latest
(qemu 9.2.0) segfault on ubuntu-24.04 / ubuntu-latest docker/setup-qemu-action#198Does this PR introduce any user-facing change?
NO
How was this patch tested?
build: CI passed push false
Note for test case:
merge commits ot
main
,v0.7.1-dev
branch✅ main: https://github.com/Yikun/vllm-ascend/actions/runs/13347238961 --> ghcr.io/yikun/vllm-ascend:main OK
✅v0.7.1-dev: https://github.com/Yikun/vllm-ascend/actions/runs/13347229912 --> ghcr.io/yikun/vllm-ascend:v0.7.1-dev OK
create pep440 tag from github release: v0.7.1rc1, v0.7.1, v0.7.1rc1.dev1 all release has latest
✅ v0.7.5 --> v0.7.5, latest
✅ v0.7.5rc1 --> v0.7.5rc1
✅ v0.7.5rc1.dev1 --> v0.7.5rc1.dev1
(no latest, add a todo here) v0.7.5rc1.post1 --> v0.7.5rc1.post1
create unknow tag from github release:
✅ create 0.7.1 on v0.7.1-dev: not trigger ( only prefix v triggerd)
create tag from git:
✅ also works,
git tag v0.7.99;git push origin v0.7.99
from publish-image