Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add container image build ci #64

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Feb 14, 2025

What this PR does / why we need it?

Add container image build ci:

Does this PR introduce any user-facing change?

NO

How was this patch tested?

build: CI passed push false
Note for test case:

  1. merge commits ot main, v0.7.1-dev branch
    ✅ main: https://github.com/Yikun/vllm-ascend/actions/runs/13347238961 --> ghcr.io/yikun/vllm-ascend:main OK
    ✅v0.7.1-dev: https://github.com/Yikun/vllm-ascend/actions/runs/13347229912 --> ghcr.io/yikun/vllm-ascend:v0.7.1-dev OK

  2. create pep440 tag from github release: v0.7.1rc1, v0.7.1, v0.7.1rc1.dev1 all release has latest
    ✅ v0.7.5 --> v0.7.5, latest
    ✅ v0.7.5rc1 --> v0.7.5rc1
    ✅ v0.7.5rc1.dev1 --> v0.7.5rc1.dev1
    (no latest, add a todo here) v0.7.5rc1.post1 --> v0.7.5rc1.post1

  3. create unknow tag from github release:
    ✅ create 0.7.1 on v0.7.1-dev: not trigger ( only prefix v triggerd)

  4. create tag from git:
    ✅ also works, git tag v0.7.99;git push origin v0.7.99 from publish-image

@Yikun Yikun force-pushed the publish-image branch 5 times, most recently from d8ae31f to 297a1c9 Compare February 14, 2025 18:13
@Yikun Yikun marked this pull request as ready for review February 15, 2025 03:19
@Yikun Yikun force-pushed the publish-image branch 4 times, most recently from fd49262 to 2a8597e Compare February 15, 2025 16:44
@Yikun Yikun marked this pull request as draft February 15, 2025 17:05
@Yikun Yikun force-pushed the publish-image branch 3 times, most recently from abe5458 to 8bd6077 Compare February 15, 2025 18:35
@Yikun Yikun marked this pull request as ready for review February 15, 2025 18:37
name: 'image'

on:
pull_request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image build will work even a pull_request is created?

Copy link
Collaborator Author

@Yikun Yikun Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, only build check without push, see the ci results in current PR.

push: ${{ github.event_name != 'pull_request' }}

otherwise, we can guarantee the docker quality, but need 30 mins to check.

the whole workflow is

  1. first PR check
  2. then auto publish branch dev image for each commits
  3. auto publish final image when tag

name: 'image'

on:
pull_request:
Copy link
Collaborator Author

@Yikun Yikun Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, only build check without push, see the ci results in current PR.

push: ${{ github.event_name != 'pull_request' }}

otherwise, we can guarantee the docker quality, but need 30 mins to check.

the whole workflow is

  1. first PR check
  2. then auto publish branch dev image for each commits
  3. auto publish final image when tag

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun
Copy link
Collaborator Author

Yikun commented Feb 16, 2025

I think it's ready to go, after this PR merged:

  1. ghcr.io/vllm-project/vllm-ascend:main will be published
  2. main branch image build check will be enable
  3. the PR should be backported to v0.7.1-dev branch (with 0.7.1 dockerfile)

@wangxiyuan wangxiyuan merged commit bfbfbce into vllm-project:main Feb 17, 2025
5 checks passed
@Yikun
Copy link
Collaborator Author

Yikun commented Feb 17, 2025

Let's monitor the results:

  1. ghcr.io/vllm-project/vllm-ascend:main: https://github.com/vllm-project/vllm-ascend/actions/runs/13360736837/job/37309987189
  2. OK
  3. v0.7.1-dev PR: [v0.7.1][CI] Add container image build ci #65

@Yikun Yikun mentioned this pull request Feb 17, 2025
33 tasks
wangxiyuan pushed a commit that referenced this pull request Feb 17, 2025
### What this PR does / why we need it?

Backport #64 to
v0.7.1-dev branch

Add container image build ci:
- Enable branch, tag docker image publish
    - branch image: `vllm-ascend:main`, `vllm-ascend:v0.7.1-dev`
    - tag image: `vllm-ascend:v0.7.1rc1`
- Enable PR docker image build check
- other changes:
    - Prepare the `REPO_OWNER` because the ghcr lowerercase required
- Add `Free up disk space` step to avoid `No space left on device` like
#27
- Setup qemu with image to resolve
docker/setup-qemu-action#198

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
build: CI passed

---------

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Feb 21, 2025
### What this PR does / why we need it?

Backport vllm-project#64 to
v0.7.1-dev branch

Add container image build ci:
- Enable branch, tag docker image publish
    - branch image: `vllm-ascend:main`, `vllm-ascend:v0.7.1-dev`
    - tag image: `vllm-ascend:v0.7.1rc1`
- Enable PR docker image build check
- other changes:
    - Prepare the `REPO_OWNER` because the ghcr lowerercase required
- Add `Free up disk space` step to avoid `No space left on device` like
vllm-project#27
- Setup qemu with image to resolve
docker/setup-qemu-action#198

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
build: CI passed

---------

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tonistiigi/binfmt:latest (qemu 9.2.0) segfault on ubuntu-24.04 / ubuntu-latest
2 participants