Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc][Build] Fix packages for finding submodule #42

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[Misc][Build] Fix packages for finding submodule #42

merged 1 commit into from
Feb 11, 2025

Conversation

MengqingCao
Copy link
Contributor

What this PR does / why we need it?

fix packages for finding submodule.
Before this pr, the wheel built by pip not contain submodule ops , thus will raise an ImportError when importing vllm

How was this patch tested?

  1. build vllm-ascend wheel by pip
cd ./vllm-ascend
pip wheel ./ --no-deps
pip install vllm_ascend-0.1.dev11+g07f2a16.d20250211-py3-none-any.whl  #change file name according to yours wheel.
  1. check vllm
import vllm

@MengqingCao
[setup] fix packages for finding submodule
79d8836 
Signed-off-by: MengqingCao <cmq0113@163.com>
@MengqingCao
Copy link
Contributor Author

cc @yiz-liu Plz check this pr, thx!

@Yikun Yikun changed the title [setup] fix packages for finding submodule [Misc][Build] Fix packages for finding submodule Feb 11, 2025
Yikun
Yikun approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yikun Yikun merged commit 86796cf into vllm-project:main Feb 11, 2025
8 checks passed
@MengqingCao MengqingCao mentioned this pull request Feb 11, 2025
Merged
@MengqingCao MengqingCao deleted the setup branch February 11, 2025 12:22
wangxiyuan pushed a commit that referenced this pull request Feb 11, 2025
@MengqingCao
[Misc][Build] Fix packages for finding submodule (#43)
02e76c6 
fix packages for finding submodule. 
see #42

Signed-off-by: MengqingCao <cmq0113@163.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Feb 21, 2025
@MengqingCao
[Misc][Build] Fix packages for finding submodule (vllm-project#43)
aec2d4d 
fix packages for finding submodule.
see vllm-project#42

Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: angazenn <zengyanjia@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yikun Yikun Yikun approved these changes

@wangxiyuan wangxiyuan wangxiyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MengqingCao @Yikun @wangxiyuan