Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade to newest pta.(MLA and FusedMoE) #189

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

SidaoY
Copy link
Contributor

@SidaoY SidaoY commented Feb 27, 2025

Upgrade to newest pta.(MLA and FusedMoE)

Signed-off-by: SidaoY <1024863041@qq.com>
Signed-off-by: SidaoY <1024863041@qq.com>
compressType=0,
kvCacheCfg=1)
torch_npu._npu_reshape_and_cache_siso(key=k_cache,
key_cache=key_cache,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of valueCache is None, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SISO interface does not transmit the valueCache.

seq_len=self.seq_lens_tensor_cpu,
scale_value=self.scale,
num_heads=self.num_heads,
num_kv_heads=self.num_heads,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be self.num_kv_heads?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two are consistent during the prefill phase, and the distinction is only made during the decode phase.

@wangxiyuan wangxiyuan merged commit 1715230 into vllm-project:main Feb 27, 2025
10 checks passed
@SidaoY SidaoY deleted the update_ds branch February 27, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants