Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add dependabot support and labeler workflow #162

Merged
merged 7 commits into from
Feb 27, 2025
+68 −2
Merged

[CI] Add dependabot support and labeler workflow #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59be8ed
add dependabot support and labeler workflow
shink Feb 25, 2025
9a1a6df
fix
shink Feb 25, 2025
789270c
update
shink Feb 25, 2025
72f4fa5
fix
shink Feb 25, 2025
557c0dc
revert
shink Feb 25, 2025
05f9f2e
update
shink Feb 26, 2025
21616c3
update
shink Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
# Check for updates to GitHub Actions every week
interval: "weekly"
open-pull-requests-limit: 2
reviewers:
- "Yikun"
38 changes: 38 additions & 0 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
documentation:
- changed-files:
- any-glob-to-any-file:
- 'docs/**'
- '**/*.md'

ci/build:
- changed-files:
- any-glob-to-any-file:
- '.github/actions/*.yml'
- '.github/workflows/*.yml'
Comment on lines +8 to +12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider easy backport to other branch, Pls contact @shen-shanshan to help to also add other labels in this PR together

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, @shen-shanshan so what do you think about labels? Would be nice if you could list them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, @shen-shanshan so what do you think about labels? Would be nice if you could list them.

Let's discuss on WeChat.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • module: tools
  • module: tests
  • module: ops
  • module: quantization
  • module: core

Copy link
Contributor Author

@shink shink Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, see this file: https://github.com/shink/vllm-ascend/blob/ci/improve/.github/labeler.yml

cc: @Yikun @shen-shanshan

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a label show the PR is for which branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangxiyuan Unfortunately, the labeler action doesn't support that, but we can do this by using gh-script.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really usefull. Please consider add one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangxiyuan Sure will add support in next PR


'module:tests':
- changed-files:
- any-glob-to-any-file:
- 'tests/**'

'module:tools':
- changed-files:
- any-glob-to-any-file:
- 'tools/**'

'module:ops':
- changed-files:
- any-glob-to-any-file:
- 'vllm_ascend/ops/**'

'module:quantization':
- changed-files:
- any-glob-to-any-file:
- 'vllm_ascend/quantization/**'

'module:core':
- changed-files:
- any-glob-to-any-file:
- 'vllm_ascend/*.py'

4 changes: 2 additions & 2 deletions .github/workflows/image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
uses: docker/setup-buildx-action@v2

- name: Publish - Login to Quay Container Registry
if: ${{ github.event_name == 'push' }}
if: ${{ github.event_name == 'push' && github.repository_owner == 'vllm-project' }}
uses: docker/login-action@v3
with:
registry: quay.io
Expand All @@ -94,7 +94,7 @@ jobs:
cache-from: type=gha
cache-to: type=gha,mode=max
# only trigger when tag, branch/main push
push: ${{ github.event_name != 'pull_request' }}
push: ${{ github.event_name == 'push' && github.repository_owner == 'vllm-project' }}
labels: ${{ steps.meta.outputs.labels }}
tags: ${{ steps.meta.outputs.tags }}
build-args: |
Expand Down
18 changes: 18 additions & 0 deletions .github/workflows/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Pull Request Labeler

on: pull_request_target

jobs:
label:
name: Label
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- name: Label the PR
uses: actions/labeler@v5
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
configuration-path: .github/labeler.yml
sync-labels: true