Skip to content

Commit

Permalink
Add container image build ci
Browse files Browse the repository at this point in the history
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
  • Loading branch information
Yikun committed Feb 16, 2025
1 parent b88443b commit 217e13b
Show file tree
Hide file tree
Showing 2 changed files with 108 additions and 3 deletions.
100 changes: 100 additions & 0 deletions .github/workflows/image.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
name: 'image'

on:
pull_request:
branches:
- 'main'
- '*-dev'
paths:
- '.github/workflows/build_image.yml'
- '.github/workflows/publish_image.yml'
- '.github/workflows/image.yml'
- 'Dockerfile'
- 'vllm_ascend/**'
push:
# Publish image when tagging, the Dockerfile in tag will be build as tag image
branches:
- 'main'
- '*-dev'
tags:
- 'v*'
paths:
- '.github/workflows/build_image.yml'
- '.github/workflows/publish_image.yml'
- '.github/workflows/image.yml'
- 'Dockerfile'
- 'vllm_ascend/**'
jobs:

build:
name: vllm-ascend image
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Prepare
run: |
REPO_OWNER=$(echo "${{ github.repository_owner }}" | tr '[:upper:]' '[:lower:]')
echo "REPO_OWNER=${REPO_OWNER}" >> "$GITHUB_ENV"
- name: Print
run: |
echo "REPO_OWNER:""${REPO_OWNER}"
- name: Docker meta
id: meta
uses: docker/metadata-action@v5
with:
# TODO(yikun): add more hub image and a note on release policy for container image
# The REPO_OWNER will be:
# - `vllm-project` in usptream repo
# - lowercase github user in your fork repo
images: |
ghcr.io/${{ env.REPO_OWNER }}/vllm-ascend
# Note for test case
# https://github.com/marketplace/actions/docker-metadata-action#typeref
# 1. branch job pulish per main/*-dev branch commits
# 2. main and dev pull_request only build is unimportant
# 3. only pep440 matched tag will be published:
# - v0.7.1 --> v0.7.1, latest
# - pre/post/dev: v0.7.1rc1/v0.7.1rc1/v0.7.1rc1.dev1/v0.7.1.post1, no latest
# (follow the rule from vLLM with prefix v)
# TODO(yikun): the post release might be considered as latest release
tags: |
type=ref,event=branch
type=ref,event=pr
type=pep440,pattern={{raw}}
- name: Free up disk space
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
with:
tool-cache: true
docker-images: false

- name: Build - Set up QEMU
uses: docker/setup-qemu-action@v2
# TODO(yikun): remove this after https://github.com/docker/setup-qemu-action/issues/198 resolved
with:
image: tonistiigi/binfmt:qemu-v7.0.0-28

- name: Build - Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Publish - Login to GitHub Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v6
with:
platforms: linux/amd64,linux/arm64
cache-from: type=gha
cache-to: type=gha,mode=max
# only trigger when tag, branch/main push
push: ${{ github.event_name != 'pull_request' }}
labels: ${{ steps.meta.outputs.labels }}
tags: ${{ steps.meta.outputs.tags }}
11 changes: 8 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,15 @@
# limitations under the License.
#

FROM quay.io/ascend/cann:8.0.rc3.beta1-910b-ubuntu22.04-py3.10
FROM quay.io/ascend/cann:8.0.0.beta1-910b-ubuntu22.04-py3.10

# Define environments
ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update -y && \
apt-get install -y python3-pip git vim
apt-get install -y python3-pip git vim && \
rm -rf /var/cache/apt/* && \
rm -rf /var/lib/apt/lists/*

WORKDIR /workspace

Expand All @@ -35,6 +37,9 @@ RUN git clone --depth 1 $VLLM_REPO /workspace/vllm
RUN VLLM_TARGET_DEVICE="empty" python3 -m pip install /workspace/vllm/

# Install vllm-ascend main
RUN python3 -m pip install /workspace/vllm-ascend/
RUN python3 -m pip install /workspace/vllm-ascend/ -f https://download.pytorch.org/whl/torch/

# Install modelscope
RUN python3 -m pip install modelscope

CMD ["/bin/bash"]

0 comments on commit 217e13b

Please sign in to comment.