feat: Add errorCallback config option to VivliostylePrint/printHTML() #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
So far VivliostylePrint has no way to handle errors. This commit adds a new config option `errorCallback` to VivliostylePrint/`printHTML()` to handle errors.
Usage example:
```ts
const config = {
errorCallback: (message) => {
alert(message);
}
};
printHTML(htmlDoc, config);
```
This commit also fixes the following issues on error handling:
- `Payload.content` type should be `ErrorInfo` instead of `string`.
- `loadDocument()` and `loadPublication()` in CoreViewer needed to fix the "No URL specified" error handling.
- `Logging.logger.addListener(level, listener)` used to push a listener to an array per level so that multiple listeners can be registered for the same level. However, that was problematic because the `Logging.logger` is a singleton instance but the CoreViewer instance with an AdaptiveViewer instance is created each time `printHTML()` is called, and new listeners are added each time without removing the old ones, causing the listeners to be duplicated. This commit changes the `addListener` method to replace the listener for the level if it already exists.
MurakamiShinyu
force-pushed
the
feat/vivliostyle-print-error
branch
from
65c5a5f to
9602d61
Compare
|
Also made a pull request for vivliostyle-print to use this errorCallback in demo: |
johanneswilm
approved these changes
Feb 23, 2024
|
NOTE: This PR solves a problem noted in #1268. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far VivliostylePrint has no way to handle errors. This PR adds a new config option
errorCallbackto VivliostylePrint/printHTML()to handle errors.Usage example:
This PR also fixes the following issues on error handling:
Payload.contenttype should beErrorInfoinstead ofstring.loadDocument()andloadPublication()in CoreViewer needed to fix the "No URL specified" error handling.Logging.logger.addListener(level, listener)used to push a listener to an array per level so that multiple listeners can be registered for the same level. However, that was problematic because theLogging.loggeris a singleton instance but the CoreViewer instance with an AdaptiveViewer instance is created each timeprintHTML()is called, and new listeners are added each time without removing the old ones, causing the listeners to be duplicated. This commit changes theLogging.logger.addListenermethod to replace the listener for the level if it already exists.#1268